properly deprecated everything #353
Conversation
| @@ -18,6 +18,7 @@ | |||
| * | |||
| * @deprecated Replaced by ROS2BehaviorTreeExecutor | |||
| */ | |||
| @Deprecated | |||
There was a problem hiding this comment.
This should be covered by the Javadoc, no?
There was a problem hiding this comment.
If you look at the warnings shown by the CI runner, it generates a warning for everywhere where deprecated is declared in the javadoc but not provided as an annotation.
| @@ -32,7 +32,7 @@ public static double[] parseDoubleArray(String stringSource) throws IOException | |||
| StringTokenizer tokenizer = new StringTokenizer(line.replace("{", "").replace("}", "").replace(" ", "").replace(";", ""), ","); | |||
| while (tokenizer.hasMoreElements()) | |||
| { | |||
| retArray.add(new Double(Double.parseDouble((String) tokenizer.nextElement()))); | |||
| retArray.add(Double.valueOf(Double.parseDouble((String) tokenizer.nextElement()))); | |||
There was a problem hiding this comment.
I would imagine this would be sufficient?
| retArray.add(Double.valueOf(Double.parseDouble((String) tokenizer.nextElement()))); | |
| retArray.add(Double.parseDouble((String) tokenizer.nextElement())); |
There was a problem hiding this comment.
I'll probably shelve this PR and do anotehr pass on cleaning up deprecations. They make the build log a pain.
| @@ -636,7 +637,7 @@ private void addLidarMounts(SDFSensor sensor, JointDescription scsJoint, SDFLink | |||
| } | |||
| else | |||
| { | |||
| System.err.println("Unknown noise model: " + sdfNoise.getType()); | |||
| LogTools.info("Unknown noise model: " + sdfNoise.getType()); | |||
There was a problem hiding this comment.
Not the case here, but it reminded me, careful doing this more broadly. Anything that executes as part of a Runtime shutdownHook can't use LogTools anymore, because log4j2 is one of the things that gets shutdown in that phase.
There was a problem hiding this comment.
No clue, if that's the case I can cahnge it back.
No description provided.