Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2194 address pr feedback and then some #2195

Merged
merged 9 commits into from
Apr 29, 2024
Merged

Commits on Apr 23, 2024

  1. 🧹 Refactor HTTP basic authentication to use dynamic credentials

    - Replace hardcoded authentication credentials in ApplicationController with class attributes.
    - Introduce an initializer to set HTTP basic auth credentials dynamically from environment variables.
    - Update the authenticate_if_needed method to utilize class attributes for username and password verification.
    ShanaLMoore committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    00870c2 View commit details
    Browse the repository at this point in the history
  2. 🧹 update favicon

    There was a mix of old + update code which caused the site to break on hyku.test, because of the favicon.
    
    It has been updated to mostly match the way pals has it.
    - scientist-softserv/palni-palci@3483da1
    ShanaLMoore committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    b0dab40 View commit details
    Browse the repository at this point in the history
  3. update formatting and remove sidekiq.rake

    Rob left feedback confirming that sidekiq.rake was removed from hyku intentionally, so we shouldn't add it back.
    ShanaLMoore committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    517646c View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Uncomment specs

    ShanaLMoore committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    89e6c90 View commit details
    Browse the repository at this point in the history
  2. add Hyrax decorator for based_near lookup issue

    passing an obj instead of a string breaks and fails bulkrax imports, when based_near is nil.
    ShanaLMoore committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    3bfa824 View commit details
    Browse the repository at this point in the history
  3. 💄 rubocop

    ShanaLMoore committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    21be5fa View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. ✅ Update raise statement to resolve spec failures

    This commit should fix the cause of spec failures in has_matchers_decorator_spec.rb
    ShanaLMoore committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    f685f92 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    405545d View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Configuration menu
    Copy the full SHA
    087e287 View commit details
    Browse the repository at this point in the history