I2194 address pr feedback and then some #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace hardcoded authentication credentials in ApplicationController with class attributes. - Introduce an initializer to set HTTP basic auth credentials dynamically from environment variables. - Update the authenticate_if_needed method to utilize class attributes for username and password verification.
There was a mix of old + update code which caused the site to break on hyku.test, because of the favicon. It has been updated to mostly match the way pals has it. - scientist-softserv/palni-palci@3483da1
Rob left feedback confirming that sidekiq.rake was removed from hyku intentionally, so we shouldn't add it back.
passing an obj instead of a string breaks and fails bulkrax imports, when based_near is nil.
This commit should fix the cause of spec failures in has_matchers_decorator_spec.rb
ShanaLMoore
force-pushed
the
i2194-address-pr-feedback
branch
from
9d9bc78
to
f685f92
Compare
kirkkwang
previously approved these changes
Apr 26, 2024
laritakr
reviewed
Apr 26, 2024
| <link rel="icon" href="<%= Site&.favicon&.url(:v128) %>" sizes="128x128"> | ||
| <link rel="icon" href="<%= Site&.favicon&.url(:v128) %>" sizes="192x192"> | ||
| <link rel="icon" href="<%= Site&.favicon&.url(:v228) %>" sizes="228x228"> | ||
| <link rel="icon" href="<%= favicon(:v32) %>" sizes="32x32"> |
There was a problem hiding this comment.
I believe the changes to this file may break the ability to upload the favicon through the Admin UI...
laritakr
requested changes
Apr 26, 2024
@laritakr I was still able to update the favicon from the admin dashboard: It used to be the samvera tree, but I updated it on the hyku-local tenant, seen below. It seems like this is to set the default mainly for the proprietor page, unless the tenant specifies otherwise. 
|
laritakr
previously approved these changes
Apr 26, 2024
kirkkwang
reviewed
Apr 29, 2024
Co-authored-by: Kirk Wang <[email protected]>
kirkkwang
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref feedback:
I will also be correcting anything else wrong that I'm noticing, while spinning up the app.
After this gets merged, we will cut a new release of hyku!
FIXES INCLUDE: