Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DX] [Experimental] Add withPhpLevel() to raise PHP level one rule at a time #6261

Merged
merged 2 commits into from
Oct 12, 2024
Merged

[DX] [Experimental] Add withPhpLevel() to raise PHP level one rule at a time #6261

merged 2 commits into from
Oct 12, 2024

Conversation

TomasVotruba
Copy link
Member

No description provided.

@TomasVotruba TomasVotruba changed the title [DX] [Experimental] Add withPhpLevel() to raise PHP lele one rule at a time [DX] [Experimental] Add withPhpLevel() to raise PHP level one rule at a time Aug 27, 2024
@TomasVotruba TomasVotruba force-pushed the tv-with-php-levels branch 2 times, most recently from 847bd5a to 9a00924 Compare August 27, 2024 13:11
@TomasVotruba TomasVotruba force-pushed the tv-with-php-levels branch 3 times, most recently from 79fef6e to 15cb9ea Compare September 1, 2024 16:02
samsonasik
samsonasik reviewed Sep 1, 2024
View reviewed changes
preload.php Outdated Show resolved Hide resolved
@TomasVotruba TomasVotruba force-pushed the tv-with-php-levels branch 10 times, most recently from a87fc6d to 6c846ca Compare September 2, 2024 08:25
@TomasVotruba TomasVotruba force-pushed the tv-with-php-levels branch 2 times, most recently from 7f2c91b to 56d7658 Compare October 12, 2024 15:41
@TomasVotruba
Copy link
Member Author

Merging this to test in the wild 👍

@TomasVotruba TomasVotruba merged commit 684f23d into main Oct 12, 2024
36 checks passed
@TomasVotruba TomasVotruba deleted the tv-with-php-levels branch October 12, 2024 15:53
@samsonasik samsonasik mentioned this pull request Oct 15, 2024
Merged
@samsonasik
Copy link
Member

It seems cause error and different web view result with empty data after used new resolveFromFilePathIncludingConfiguration() on getrector.com when used, I copy paste original resolveFromFilePath() method into getrector.com at

to ensure it has equal result.

samsonasik
samsonasik reviewed Oct 16, 2024
View reviewed changes
src/Configuration/RectorConfigBuilder.php

$this->isWithPhpLevelUsed = true;

$phpVersion = ComposerJsonPhpVersionResolver::resolveFromCwdOrFail();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should allow read from withPhpVersion() defined from Rector config so it can be tested on getrector.com, which PhpVersionProvider seems can be used, or add fallback on ComposerJsonPhpVersionResolver to use predefined from withPhpversion() config when exists

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created experiment PR at #6384

@samsonasik samsonasik mentioned this pull request Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staabm staabm staabm left review comments

@samsonasik samsonasik samsonasik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomasVotruba @samsonasik @staabm