Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automated] Update Rector Dependencies #2630

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

TomasVotruba
Copy link
Member

Automated changes by create-pull-request GitHub action

@TomasVotruba TomasVotruba enabled auto-merge (squash) October 12, 2024 18:05
@TomasVotruba TomasVotruba force-pushed the automated-regenerated-composer-lock branch from 9d3d17d to 61660fc Compare October 13, 2024 12:07
@TomasVotruba TomasVotruba force-pushed the automated-regenerated-composer-lock branch from 61660fc to b5ff312 Compare October 15, 2024 18:06
@samsonasik samsonasik self-assigned this Oct 15, 2024
@samsonasik
Copy link
Member

I will check the error notice due to renamed method resolveFromFilePath() at PR:

@samsonasik
Copy link
Member

Fixed 🎉 a14354a

@samsonasik
Copy link
Member

Now got error:

  src/Sets/RectorSetsTreeProvider.php:104
 ------------------------------------------------------------------------
  - '#Parameter \#3 \$rectorClasses of class App\\RuleFilter\\ValueObject\\RectorSet constructor expects array<class\-string<Rector\\Contract\\Rector\\RectorInterface>>, array<int, array<class\-string<Rector\\Contract\\Rector\\RectorInterface>, array>\|class\-string<Rector\\Contract\\Rector\\RectorInterface>> given#'
  - 

@samsonasik
Copy link
Member

I copy paste original method resolveFromFilePath() private method into here to ensure the functinality is same :)

@TomasVotruba TomasVotruba merged commit f043f21 into main Oct 15, 2024
6 checks passed
@TomasVotruba TomasVotruba deleted the automated-regenerated-composer-lock branch October 15, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants