Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scrolling issue with coverart columns visible #13719

Open
wants to merge 14 commits into
base: 2.4
Choose a base branch
from
Open

Fix scrolling issue with coverart columns visible #13719

wants to merge 14 commits into from

Commits on Sep 29, 2024

  1. Fix double reference detection. 

    The ID is the unique ID which is always returned. When finding a track by canonical location, without an ID, verify that the location stored in the database which can contain symlinks is also matching. If not a different track referencing that same file is already cached and we need to return null to not introduce a data race.

This avoids the issue that wrong track can be returned when using drag and drop.
    @daschuer
    daschuer committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    cad77fa View commit details
    Browse the repository at this point in the history

  2. fix misleading "File not found" warning in TrackDAO::addTracksAddFile… 

    …() by a proper handling of GlobalTrackCacheLookupResult.
    @daschuer
    daschuer committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    926bc42 View commit details
    Browse the repository at this point in the history

  3. Remove redundant warning from TrackDAO::getOrAddTrack(), there is alr… 

    …eady a more significant warning about the dupicate situation.
    @daschuer
    daschuer committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    139dfb0 View commit details
    Browse the repository at this point in the history

  4. Fix wrong DEBUG_ASSERTs in TrackDAO::getTrackById() and refine comments.

    @daschuer
    daschuer committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    5379a71 View commit details
    Browse the repository at this point in the history

  5. Fix typos 

    Co-authored-by: ronso0 <[email protected]>
    @daschuer @ronso0
    daschuer and ronso0 authored Sep 29, 2024
    Configuration menu
    Copy the full SHA
    b8e3309 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Improve comments

    @daschuer
    daschuer committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    84e27f7 View commit details
    Browse the repository at this point in the history

  2. delete unimplemented ctor GlobalTrackCacheResolver()

    @daschuer
    daschuer committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    426c023 View commit details
    Browse the repository at this point in the history

  3. remove unused friend class

    @daschuer
    daschuer committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    86fbd67 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Introduce a single m_incompleteTrack track and protect it by a QWaitC… 

    …ondition
    @daschuer
    daschuer committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    803ddf8 View commit details
    Browse the repository at this point in the history

  2. Fix GlobalTrackCacheTest.resolveByFileInfo

    @daschuer
    daschuer committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    67b57d8 View commit details
    Browse the repository at this point in the history

  3. Inline getTrackIdByRef() to avoid looking up a cached track form libr… 

    …ary.
    @daschuer
    daschuer committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a8bc7a7 View commit details
    Browse the repository at this point in the history

  4. remove unused addTracksAddFile() overload

    @daschuer
    daschuer committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    0a25713 View commit details
    Browse the repository at this point in the history

  5. Add an option to resolve a temporary track for the case when metadata… 

    … shall not be stored in library and track file.
    @daschuer
    daschuer committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    4555133 View commit details
    Browse the repository at this point in the history

  6. Use a cached temporary track when looking up cover arts form file met… 

    …adata. This fixes a priority inversion when scrolling the library mixxxdj#11128
    @daschuer
    daschuer committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    357d1d1 View commit details
    Browse the repository at this point in the history