Fix scrolling issue with coverart columns visible #13719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ID is the unique ID which is always returned. When finding a track by canonical location, without an ID, verify that the location stored in the database which can contain symlinks is also matching. If not a different track referencing that same file is already cached and we need to return null to not introduce a data race. This avoids the issue that wrong track can be returned when using drag and drop.
…() by a proper handling of GlobalTrackCacheLookupResult.
…eady a more significant warning about the dupicate situation.
Co-authored-by: ronso0 <[email protected]>
… shall not be stored in library and track file.
…adata. This fixes a priority inversion when scrolling the library mixxxdj#11128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally fixing a long standing and puzzling bug that momentary locks up Mixxx during scrolling the library with cover art enabled. #11128
The issue happens due to a priory inversion on the track cache mutex. During cover art reading the cache is locked to protect this incomplete track, which prevents the main thread checking for pending modifications on cached tracks. Scrolling continues when all covers are read even it is done in worker threads.
The solution implemented here is to allow to bypass the lock in case the current track populated, yet still incomplete track is not of interest. It is implemented by limiting that actual look for the track cache only for aching actions and use a wait condition in case a thread is waiting for completing an incomplete track.
Now scrolling is smooth all the time and together with removing unnecessary painting #13715 also quite fast.
This PR is on top of #13708 which should be merged first.