Fix loading the wrong track via drag and drop and fix wrong DEBUG_ASSERT #13708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ID is the unique ID which is always returned. When finding a track by canonical location, without an ID, verify that the location stored in the database which can contain symlinks is also matching. If not a different track referencing that same file is already cached and we need to return null to not introduce a data race. This avoids the issue that wrong track can be returned when using drag and drop.
…() by a proper handling of GlobalTrackCacheLookupResult.
…eady a more significant warning about the dupicate situation.
ronso0
reviewed
Sep 29, 2024
ronso0
reviewed
Sep 29, 2024
Co-authored-by: ronso0 <[email protected]>
|
Just an idea how to allow users fixing the situation in Mixxx:
|
|
Sounds good. Can we merge this now since this is IMHO a 2.4.2 bug fix. |
|
I consider this ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes handling with duplicated tracks #13706. Now an attempt for caching two tracks with different locations referencing the same file are reliably detected and rejected the situation is reported as warning, and does no longer violates assertions.
This has been tested on Ubuntu focal using a symlink
ln -s track.mp3 symlink.mp3The related issues showing the empty property page and overwriting thee symlink #13707 are still pending, work is in progress.