Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make basic community membership guidelines clearer #3827

Conversation

anishasthana
Copy link
Contributor

@anishasthana anishasthana commented Jul 24, 2024

This PR adds guidelines around the kubeflow community membership.

This set of guidelines is heavily inspired by the Kubernetes guidelines at https://github.com/kubernetes/community/blob/master/community-membership.md?plain=1#community-membership

cc @kubeflow/kubeflow-steering-committee

Copy link

Hi @anishasthana. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

cc @terrytangyuan

@google-oss-prow google-oss-prow bot added the lgtm label Jul 25, 2024
@anishasthana anishasthana changed the title Make basic community membership guidelines clearer WIP: Make basic community membership guidelines clearer Aug 7, 2024
@anishasthana anishasthana force-pushed the update_community_membership_guidelines branch from 2931fd6 to 4b3de1b Compare August 7, 2024 01:29
@anishasthana anishasthana force-pushed the update_community_membership_guidelines branch 2 times, most recently from b17b1ac to b0d245b Compare August 7, 2024 14:30
@anishasthana anishasthana force-pushed the update_community_membership_guidelines branch 2 times, most recently from 908075a to 90c127a Compare August 7, 2024 14:35
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a great improvements over the current process. Thanks!

One thing that is being discussed is how to encourage non-code contributions. This may not be something this PR covers and can be future improvements IMO. I'll share with the outreach team to help review.

@andreyvelich
Copy link
Member

@anishasthana Did you address all of the comments from this PR: kubeflow/community#737?
Is this PR ready for the second review ?

/assign @kubeflow/wg-training-leads @kubeflow/wg-automl-leads @kubeflow/wg-notebooks-leads @kubeflow/wg-pipeline-leads @kubeflow/wg-data-leads

@anishasthana
Copy link
Contributor Author

@andreyvelich this PR is ready for second review

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anishasthana I believe a clearer guideline helps a lot !

Wdyt about the suggestions below, based on previously received feedback.
Thank you for your consideration in any case.

content/en/docs/about/membership.md Outdated Show resolved Hide resolved
content/en/docs/about/membership.md Outdated Show resolved Hide resolved
@terrytangyuan terrytangyuan changed the title WIP: Make basic community membership guidelines clearer Make basic community membership guidelines clearer Sep 24, 2024
@anishasthana anishasthana force-pushed the update_community_membership_guidelines branch from 63c319b to 1511875 Compare September 30, 2024 19:36
README.md Outdated Show resolved Hide resolved
@anishasthana anishasthana force-pushed the update_community_membership_guidelines branch from 1511875 to 84b0336 Compare September 30, 2024 19:41
@anishasthana anishasthana force-pushed the update_community_membership_guidelines branch 4 times, most recently from dc2d259 to 96cb2ee Compare September 30, 2024 19:56
@anishasthana
Copy link
Contributor Author

image

Looks like usage of the layout is causing this. I'm not sure what's up... taking a look

@anishasthana anishasthana force-pushed the update_community_membership_guidelines branch from 96cb2ee to 31cc339 Compare September 30, 2024 20:03
@anishasthana
Copy link
Contributor Author

image
aaand fixed. @andreyvelich Please take a look!

@anishasthana anishasthana force-pushed the update_community_membership_guidelines branch from 31cc339 to e85e50d Compare September 30, 2024 22:07
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this effort @anishasthana!
/lgtm
/assign @terrytangyuan @kubeflow/kubeflow-steering-committee @hbelmiro @StefanoFioravanzo

@terrytangyuan
Copy link
Member

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 1c82bad into kubeflow:master Sep 30, 2024
6 checks passed
@anishasthana anishasthana deleted the update_community_membership_guidelines branch October 1, 2024 01:08
@tarilabs
Copy link
Member

tarilabs commented Oct 1, 2024

thank you @anishasthana for this work, makes a great improvement on governance aspects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants