Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup on contributing guide #737

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anishasthana
Copy link

Opening a WIP PR to provide a forum for us to discuss the for community membership guidelines topic.

This set of guidelines is heavily inspired by the Kubernetes guidelines at https://github.com/kubernetes/community/blob/master/community-membership.md?plain=1#community-membership

Closes #736

cc @kubeflow/kubeflow-steering-committee. I'll defer to your expertise/recommendations here!

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @ananth102, thank you for driving this!
I will cc WG leads to review this, and we should follow this guidelines across all Kubeflow projects once we finalize it.

/assign @kubeflow/kubeflow-steering-committee @kubeflow/wg-data-leads @kubeflow/wg-notebooks-leads @kubeflow/wg-training-leads @kubeflow/wg-automl-leads @kubeflow/wg-pipeline-leads @kubeflow/wg-manifests-leads

membership.md Outdated Show resolved Hide resolved
membership.md Outdated Show resolved Hide resolved
membership.md Outdated Show resolved Hide resolved
membership.md Outdated Show resolved Hide resolved
membership.md Outdated Show resolved Hide resolved
membership.md Outdated Show resolved Hide resolved
membership.md Outdated Show resolved Hide resolved
membership.md Outdated Show resolved Hide resolved
membership.md Outdated Show resolved Hide resolved
membership.md Outdated Show resolved Hide resolved
membership.md Outdated Show resolved Hide resolved
@andreyvelich
Copy link
Member

andreyvelich commented Aug 5, 2024

I think, as part of this initiative, we say that all Kubeflow WGs should follow this process for contributors promotion.
Also, we might want to remove promotion requirements from the WGs charters. For example:

Signed-off-by: Anish Asthana <[email protected]>
@google-oss-prow google-oss-prow bot added size/S and removed size/L labels Aug 6, 2024
@anishasthana anishasthana changed the title WIP: Propose Membership Guidelines Minor cleanup on contributing guide Aug 7, 2024
@anishasthana
Copy link
Author

I've moved all the membership related changes over to kubeflow/website#3827.
@andreyvelich @tarilabs @StefanoFioravanzo @juliusvonkohout @james-jwu fyi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document clear community membership guidelines
5 participants