Use prettyprinter-compat-ansi-wl-pprint as an implementation #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RyanGlScott, do you have an opinion on this? |
RyanGlScott
reviewed
May 16, 2023
| @@ -1,7 +1,6 @@ | |||
| cabal-version: >= 1.10 | |||
| name: ansi-wl-pprint | |||
| version: 0.6.9 | |||
| x-revision: 4 | |||
| version: 1.0.2 | |||
There was a problem hiding this comment.
Why pick version 1.0.2 instead of, say, 1.0.0?
There was a problem hiding this comment.
It's the same version as https://hackage.haskell.org/package/prettyprinter-compat-ansi-wl-pprint
phadej
force-pushed
the
prettyprinter
branch
2 times, most recently
from
315bab5
to
16e620b
Compare
RyanGlScott
approved these changes
May 17, 2023
|
Note that there are other incompatibilities: quchen/prettyprinter#246. These ideally ought to have been mentioned in the release notes, but at least this package was given a major version bump when switching over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26, as with this patch you'll end up using
prettyprinter.Before:
After:
The green text is done with
and that doesn't work with
Prettyprinter'sDoc(which doesn't use annotations inShowinstance).Otherwise compat shim seems to be quite complete, as none of imports needed to be removed.
This will finally make
ansi-wl-pprintobsolete.