Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prettyprinter-compat-ansi-wl-pprint is not quite a drop-in replacement as claimed #246

Open
georgefst opened this issue Aug 5, 2023 · 1 comment
Open

prettyprinter-compat-ansi-wl-pprint is not quite a drop-in replacement as claimed #246

georgefst opened this issue Aug 5, 2023 · 1 comment

Comments

@georgefst
Copy link
Contributor

This was noticed in ekmett/ansi-wl-pprint#32 (comment), but I've found some other incompatibilities:

  • There's no Pretty a => Pretty (Maybe a) instance, which old code may rely on.
  • We have Doc = Doc AnsiStyle, which means that any existing Pretty instances which use basic functions like text no longer compile, since prettyprinter's pretty has to be annotation-polymorphic.

These are not easily solved, so I think the README ought to just be clearer about the limitations.

This has caused issues for some ansi-wl-pprint-dependent packages, such as tmp-postgres.
@georgefst georgefst mentioned this issue Aug 5, 2023
Merged
@georgefst
Copy link
Contributor Author

This has caused issues for some ansi-wl-pprint-dependent packages, such as tmp-postgres.

jfischoff/tmp-postgres#279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@georgefst