-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@clack/core): keyboard input not working after await in spinner #182
Conversation
🦋 Changeset detectedLatest commit: a04e418 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
that indeed fixes the issues, I just wonder why it only affects the second call |
0c03257
to
e5089d4
Compare
e5089d4
to
a04e418
Compare
We actually don't need On linux, I'll add my suggestions on separated lines so that it can be marked as solved if implemented or discuss specifics parts of the suggestion. |
Hey @natemoo-re friendly bump: any chance this PR could get reviewed and merged in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix and thanks for your patience!
Any news?When will a new version be released? @natemoo-re |
Fix #176
Description
The issue occurred on Windows, when the await line between the spinner start and stop was present, causing the second following prompt to be unresponsive to key inputs (e.g., arrow keys or Ctrl-C), except for the [Enter] key. Additionally, this resulted in the duplication of the first option.
Solution
The solution is identify when it is running on Windows and do not change terminal's mode
Tested Environment:
OS: Windows, Ubuntu
Node Version: v18.17.1
Package: @clack/prompts
Package Version: v0.7.0
Snippet to Reproduce