Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard stucked on "Which framework, bundler or build tool are you using?" #492

Closed
lucas-zimerman opened this issue Nov 9, 2023 · 16 comments · Fixed by #539
Closed

Keyboard stucked on "Which framework, bundler or build tool are you using?" #492

lucas-zimerman opened this issue Nov 9, 2023 · 16 comments · Fixed by #539
Assignees

Comments

@lucas-zimerman
Copy link
Contributor

lucas-zimerman commented Nov 9, 2023

Environment

What version are you running? Etc.

latest | 3.9.0 (also tested with 3.16.2)

Steps to Reproduce

I have selected a project, when the screen to select the framework was shown, I could only select "anglular", pressing the arrow up and arrow down key didn't move the cursor to other options.

Expected Result

To select another option than Angular

Actual Result

image I can't say alot, but I know previously this option was allowing me to select other frameworks.

EDIT:
image
I believe it may be wrongly reading the keyboard, maybe it's reaching an entire line and allowing it to type anything during this menu instead of reading a single char and processing it?

@lucas-zimerman
Copy link
Contributor Author

package.json.-.sentry-capacitor.-.Visual.Studio.Code.2023-11-09.16-04-23.mp4

Added a video to show what is going on, it seems like it enters a code that reads a line, and once you press enter, it start a loop for reading the arrow keys and selecting which framework I should use.

@Lms24
Copy link
Member

Lms24 commented Nov 10, 2023

I tried reproducing this but I can't on MacOS. Wondering if this is a Windows-specific problem. Would you mind raising an issue in https://github.com/natemoo-re/clack? That's the library we use for the CLI prompts.

@the133448
Copy link

+1 Also having this problem. @Lms24 I don't think it would be a problem with the upstream lib for reading prompts as the previous multi select prompt for Sentry project works fine on windows.

Copy link

github-actions bot commented Dec 7, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@igorcrevar
Copy link

I have exactly the same problem: Windows 11, React app

@lucas-zimerman
Copy link
Contributor Author

bombshell-dev/clack#176
The spinner is breaking it once we stop it

@lucas-zimerman
Copy link
Contributor Author

I suggested some fixes on the library but if they aren't merged we probably can just clone the spinner and apply the fixes locally.

@Lms24
Copy link
Member

Lms24 commented Dec 22, 2023

@lucas-zimerman thanks a lot! Also saw the PR that's fixing this in the clack repo.

we probably can just clone the spinner and apply the fixes locally

Yup, we did this before a while ago. Suggestion: let's give them a bit of time over the holidays and then apply the fix locally if still necessary.

@Lms24
Copy link
Member

Lms24 commented Jan 9, 2024

This came up again in #523. Let's give them two more weeks otherwise we have to vendor in the fix. (this might generally be a reason to look for alternatives to clack)

@marty0678
Copy link

Having this issue too, is there a workaround in the mean time aside from setting up the environment in WSL or something?

@lucas-zimerman
Copy link
Contributor Author

lucas-zimerman commented Jan 19, 2024

Having this issue too, is there a workaround in the mean time aside from setting up the environment in WSL or something?

I usually just press the enter key when it happens so it unlocks the keyboard

@marty0678
Copy link

Interesting, that didn't work for me (nothing on the keyboard worked). I just manually set it up in the end.

@fmgrafikdesign
Copy link

Same issue on Win10 for a vue 3 app, initiated via npx @sentry/wizard@latest -i sourcemaps. It preselects "I use another tool [...]" and doesn't let me select anything else. I tried it with both cmd.exe and powershell.exe.

@Lms24
Copy link
Member

Lms24 commented Feb 2, 2024

I talked to the clack maintainer and he's going to take a look at the open PR fixing this issue soon. Let's give them a couple of more days.

@gramliu
Copy link
Contributor

gramliu commented Feb 24, 2024

+1 I am also experiencing this issue on Windows. I do see that the fix on clack got merged recently though: bombshell-dev/clack#182

@Lms24
Copy link
Member

Lms24 commented Feb 26, 2024

Hey all, version 3.20.5 of the wizard should fix this problem. Please let us know if the problem still persists or if it is fixed, thanks 🙏

Also props to @gramliu for contributing the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

9 participants