Remove PackedIntArray #21682
Remove PackedIntArray #21682
Conversation
|
Should we send it to the orphanage? |
|
given that part of the reasoning for proposing its removal were design flaws i dont think that's necessary. anyone who goes looking for it will still be able to find it in git |
| std.mem.writePackedInt( | ||
| u2, | ||
| &if_kind, | ||
| if_level * 2, | ||
| until_endif, | ||
| native_endian, | ||
| ); |
There was a problem hiding this comment.
It's a small thing, but you could use writePackedIntNative here to save a line in each instance.
| } else if (if_level == 1) { | ||
| guard_name = null; | ||
| } | ||
| switch (if_kind.get(if_level)) { | ||
| switch (std.mem.readPackedInt(u2, &if_kind, if_level * 2, native_endian)) { |
There was a problem hiding this comment.
..and readPackedIntNative in these instances, though it hardly saves anything.
For what it is worth I agree. Anyone looking to replicate the more complicated functionality is better off implementing it from scratch using read/writePackedInt functions. I was actually going to do that, but I couldn't find any instances of anyone actually using the more complicated functionality anyway. |
| @@ -430,12 +430,12 @@ fn preprocessExtra(pp: *Preprocessor, source: Source) MacroError!TokenWithExpans | |||
| if_level = sum; | |||
|
|
|||
| if (try pp.expr(&tokenizer)) { | |||
| if_kind.set(if_level, until_endif); | |||
| std.mem.writePackedIntNative(u2, &if_kind, if_level * 2, until_endif); | |||
There was a problem hiding this comment.
if_level * 2 will overflow if it's greater than 127. I have a PR up for aro Vexu/arocc#787 that you can grab once it's approved and passing CI (it's waiting for @splat for arrays to be available in pre-built zig).
|
Thanks! |
Fixes #21676