use constants instead of hardcoded values

Signed-off-by: davidwin93 <[email protected]>
zapier · Oct 24, 2023 · b2892d0 · b2892d0
1 parent cb5681c
commit b2892d0
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/pkg/comment_formatter/tfc_status_update.go b/pkg/comment_formatter/tfc_status_update.go
@@ -54,7 +54,7 @@ func FormatRunStatusCommentBody(tfc tfc_api.ApiClient, run *tfe.Run, rmd runstre
 	case tfe.RunDiscarded:
 		// no extra info
 	case tfe.RunErrored:
-		if rmd.GetAction() == "plan" {
+		if rmd.GetAction() == runstream.PlanAction {
 			extraInfo += failedPlanSummaryFormat
 		}
 

diff --git a/pkg/runstream/constants.go b/pkg/runstream/constants.go
@@ -0,0 +1,6 @@
+package runstream
+
+const (
+	ApplyAction string = "apply"
+	PlanAction  string = "plan"
+)
diff --git a/pkg/vcs/github/run_events_worker.go b/pkg/vcs/github/run_events_worker.go
@@ -92,7 +92,7 @@ func (w *RunEventsWorker) postRunStatusComment(ctx context.Context, run *tfe.Run
 		if len(run.TargetAddrs) > 0 {
 			return
 		}
-		if rmd.GetAction() == "apply" {
+		if rmd.GetAction() == runstream.ApplyAction {
 			w.mergePRIfPossible(ctx, rmd)
 		}
 	}

diff --git a/pkg/vcs/gitlab/mr_status_updater.go b/pkg/vcs/gitlab/mr_status_updater.go
@@ -25,7 +25,7 @@ func (p *RunStatusUpdater) updateCommitStatusForRun(ctx context.Context, run *tf
 	// https://www.terraform.io/cloud-docs/api-docs/run#run-states
 	case tfe.RunPending:
 		// The initial status of a run once it has been created.
-		if rmd.GetAction() == "plan" {
+		if rmd.GetAction() == runstream.PlanAction {
 			p.updateStatus(ctx, gogitlab.Pending, "plan", rmd)
 			p.updateStatus(ctx, gogitlab.Failed, "apply", rmd)
 		} else {
@@ -79,7 +79,7 @@ func (p *RunStatusUpdater) updateCommitStatusForRun(ctx context.Context, run *tf
 			p.updateStatus(ctx, gogitlab.Pending, "apply", rmd)
 		} else {
 			// if the apply returns no changes we can still go ahead and merge if auto-merge is enabled
-			if len(run.TargetAddrs) == 0 && rmd.GetAction() == "apply" {
+			if len(run.TargetAddrs) == 0 && rmd.GetAction() == runstream.ApplyAction {
 				p.mergeMRIfPossible(ctx, rmd)
 			}
 		}