Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] remove duplicate code and refactor trade date #1792

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zhnlk
Copy link

@zhnlk zhnlk commented Mar 24, 2022

QUANTAXIS PR 😇

感谢您对于QUANTAXIS的项目的参与~ 🛠请在此完善一下最后的信息~

注意

  • 如果非第一次fork, 请先将quantaxis 库的内容PR进您的项目进行更新, 然后再执行对于quantaxis的pr
  • 请完善CHANGELOG再进行PR

PR前必看

请使用如下代码对要PR的代码进行格式化:

使用以下代码来格式化

pip install https://github.com/google/yapf/archive/master.zip
yapf -i --style .style.yapf <file>

🛠该PR主要解决的问题🛠:

[fix] remove duplicate code] 移除重复代码
[feat] fix trade date with trade date exi] 改进交易时间的计算

作者信息:
时间:

@pep8speaks
Copy link

pep8speaks commented Mar 24, 2022

Hello @zhnlk! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 58:80: E501 line too long (115 > 79 characters)
Line 64:80: E501 line too long (115 > 79 characters)
Line 71:80: E501 line too long (115 > 79 characters)
Line 77:80: E501 line too long (115 > 79 characters)
Line 80:80: E501 line too long (87 > 79 characters)
Line 84:80: E501 line too long (115 > 79 characters)
Line 90:80: E501 line too long (115 > 79 characters)
Line 96:80: E501 line too long (115 > 79 characters)
Line 99:80: E501 line too long (87 > 79 characters)
Line 102:80: E501 line too long (101 > 79 characters)
Line 103:80: E501 line too long (101 > 79 characters)
Line 113:80: E501 line too long (101 > 79 characters)
Line 118:80: E501 line too long (101 > 79 characters)
Line 141:80: E501 line too long (87 > 79 characters)
Line 223:80: E501 line too long (87 > 79 characters)
Line 227:80: E501 line too long (87 > 79 characters)
Line 230:80: E501 line too long (101 > 79 characters)
Line 235:80: E501 line too long (101 > 79 characters)
Line 238:80: E501 line too long (101 > 79 characters)
Line 243:80: E501 line too long (101 > 79 characters)

Comment last updated at 2022-03-24 05:41:32 UTC

@zhnlk zhnlk changed the title [fix] remove duplicate code [fix] remove duplicate code and refactor trade date Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants