Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove auth headers from logger #792

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mckayb
Copy link

@mckayb mckayb commented Feb 2, 2020

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Was using JWT's in a personal project and realized it was logging all of them when they'd make a request. I have a workaround in the app, but figured this was potentially an easy change if you wanted something like that in here.

@snoyberg
Copy link
Member

snoyberg commented Feb 3, 2020

  1. This breaks all of the CI builds
  2. I don't want to make a major version bump for this
  3. If you believe this feature is in fact a breaking change (I tend to agree), please gate it behind some kind of configuration flag so this is a minor version bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants