Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): reducing 50% of a11y issues on contributor page #79

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(a11y): reducing 50% of a11y issues on contributor page #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7da69f6
fix(a11y): reducing 50% of a11y issues on contributor page
StephNathai Oct 20, 2023
929adf3
fix(a11y): removing leading spaces
StephNathai Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions _sass/_contributing.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,8 @@
font-size: 1.2em;
padding: 1em 0 0;
}

a {
text-decoration: underline;
}
}
8 changes: 4 additions & 4 deletions contributing/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,23 +22,23 @@
<ol class="description">

<li> Look through the existing issues and see if your idea is something new. </li>
<li> Create a <a href="https://github.com/yargs/yargs/issues"> new issue </a>, or comment on an existing issue that you would like to help solve:
<li> Create a <a href="https://github.com/yargs/yargs/issues">new issue</a>, or comment on an existing issue that you would like to help solve:
<ul>
<li> it's usually best to get some feedback before proceeding to write code. ,</li>
</ul>
</li>

<li> fork the yargs repo, and clone it to your computer:
<ul>
<li> GitHub has <a href="https://help.github.com/articles/using-pull-requests/"> great documentation </a> regarding writing your first pull request. </li>
<li> GitHub has <a href="https://help.github.com/articles/using-pull-requests/">great documentation</a> regarding writing your first pull request. </li>
</ul>
</li>

<li> make sure that you write unit-test for any code that you write for yargs:
<ul>
<li> we use <a href="https://github.com/feross/standard"> standard </a> coding style, which will validate your style when you run tests </li>
<li> we use <a href="https://github.com/feross/standard">standard</a> coding style, which will validate your style when you run tests </li>

<li> look through our extensive test suite in <a href="https://github.com/yargs/yargs/issues"> /test </a> to get an idea for how to write unit-tests for this codebase. </li>
<li> look through our extensive test suite in <a href="https://github.com/yargs/yargs/issues">/test</a> to get an idea for how to write unit-tests for this codebase. </li>
</ul>
</li>

Expand Down