Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Lazy_import not return None in a shared python env that contains cuda-related files on a cpu-only machine #50

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ChengjieLi28
Copy link
Contributor

@ChengjieLi28 ChengjieLi28 commented Jul 18, 2023

Related xorbitsai/xorbits#595

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added bug Something isn't working gpu labels Jul 18, 2023
@XprobeBot XprobeBot added this to the v0.0.9 milestone Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #50 (f71ffa7) into main (2683f2e) will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   89.00%   89.10%   +0.10%     
==========================================
  Files          47       47              
  Lines        3991     3991              
  Branches      760      760              
==========================================
+ Hits         3552     3556       +4     
+ Misses        356      350       -6     
- Partials       83       85       +2     
Flag Coverage Δ
unittests 88.92% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChengjieLi28 ChengjieLi28 force-pushed the bug/detect_card_in_lazy_import branch from 3ebaa68 to c318f91 Compare August 3, 2023 09:14
@XprobeBot XprobeBot modified the milestones: v0.0.9, Temp Aug 5, 2023
@XprobeBot XprobeBot modified the milestones: v0.1.0, v0.1.1 Aug 14, 2023
@XprobeBot XprobeBot modified the milestones: v0.1.1, v0.1.2 Sep 8, 2023
@XprobeBot XprobeBot modified the milestones: v0.3.0, v0.3.1, v0.3.2, v0.3.3 Jul 10, 2024
@XprobeBot XprobeBot modified the milestones: v0.3.3, v0.3.4 Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gpu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants