Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push various code signing related settings to xcconfig #23678

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Oct 18, 2024

Relates to the request to support building for Mac, see pdnsEh-1Sc-p2, but does not make it possible yet. This is mostly a preparatory tidy up.

Regression Notes

  1. Potential unintended areas of impact – N.A.
  2. What I did to test those areas of impact (or what existing automated tests I relied on) – N.A.
  3. What automated tests I added (or what prevented me from doing so) – N.A.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes. N.A.
  • I have considered adding accessibility improvements for my changes. N.A.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

UI changes testing checklist: Not a UI PR.

@mokagio mokagio added the Tooling Build, Release, and Validation Tools label Oct 18, 2024
@mokagio mokagio added this to the 25.5 milestone Oct 18, 2024
@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23678-163f6ab
Version25.4
Bundle IDcom.jetpack.alpha
Commit163f6ab
App Center Buildjetpack-installable-builds #9874
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23678-163f6ab
Version25.4
Bundle IDorg.wordpress.alpha
Commit163f6ab
App Center BuildWPiOS - One-Offs #10832
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@@ -0,0 +1,3 @@
#include "Common.xcconfig"

DEVELOPMENT_TEAM = 99KV9Z6BKV
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to create a single "enterprise" file instead of two dedicated "internal" and "alpha" because for the moment the two configuration use the same value. If/when we'll need build configuration-specific build settings, we can add dedicated files for them.

@mokagio mokagio added this pull request to the merge queue Oct 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tooling Build, Release, and Validation Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants