Replace native WP.com sign in with web-based sign in #23675
Conversation
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23675-7e582a0 | |
| Version | 25.4 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 7e582a0 | |
| App Center Build | WPiOS - One-Offs #10830 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23675-7e582a0 | |
| Version | 25.4 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 7e582a0 | |
| App Center Build | jetpack-installable-builds #9872 |
There was a problem hiding this comment.
I tested the flow, including logging-in with a new account in the web view and using passkeys. The flow works well.
It is a bit of a downgrade compared to the current implementation where the app prompts you to use one of the saved credentials from the Apple Passwords on first launch. Perhaps web views should be reserved for self-hosted sites and for wp.com account creation.
| } else { | ||
| wpAssertionFailure("WP.com web login failed", userInfo: ["error": "\(error)"]) | ||
| } | ||
| return |
There was a problem hiding this comment.
(nit) Extract the first part into a separate method so that there is no return in the middle of this long method.
There was a problem hiding this comment.
Addressed in 43409de
| // TODO: Replce with a remote feature flag. | ||
| // Enable web-based login for debug builds until the remote feature flag is available. | ||
| #if DEBUG | ||
| let webLoginEnabled = true |
There was a problem hiding this comment.
If there is no need to update the flag remotely, you can use extension FeatureFlag: RolloutConfigurableFlag { to implement the percentage-based rollout locally.
There was a problem hiding this comment.
In that case, we'd need to release the app to update the rollout percentage, right?
There was a problem hiding this comment.
Personally, I'd prefer a remote feature flag because we can completely turn it off if there are horrible issues.
| func signIn(from viewController: UINavigationController) async { | ||
| let token: String | ||
| do { | ||
| token = try await authenticate(from: viewController) |
There was a problem hiding this comment.
The animation at the top is distracting.
Untitled.mp4
There was a problem hiding this comment.
I'm not sure why it looks like this for me. It's different on your recording. I think there is a bug with the first welcome page.
The web based sign-in flow is enabled on debug builds. But it will be hidden under a feature flag later.
sign-in.mp4
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: