-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tooling] finalize_release
lane: Add back hotfix validation and remove unused lane parameter
#23674
Conversation
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
fastlane/lanes/release.rb
Outdated
desc 'Trigger the final release build on CI' | ||
lane :finalize_release do |options, skip_confirm: false| | ||
lane :finalize_release do |skip_confirm: false| | ||
UI.user_error!('To finalize a hotfix, please use the `finalize_hotfix_release` lane instead') if release_is_hotfix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's something about "release_is_hotfix?
" that sounds odd.
I was going to suggest adding branch in the name, but that would be incorrect because the check is on the version file not the branch name.
Maybe current_version_is_hotfix?
or is_hotfix?
.
Not sure...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got this method from Woo, which seems to have its name based on a release-toolkit
method, but I agree -- renamed to current_version_hotfix?
on 38ac3e5.
5153131
to
0245a0c
Compare
0245a0c
to
38ac3e5
Compare
Follow up to the release backmerge #23673, where a couple of errors had to be fixed after running
finalize_release
: the laneios_current_branch_is_hotfix
was removed fromrelease-toolkit
but was still being used, and theoptions
parameter was removed while still being passed todownload_localized_strings_and_metadata
(though not used).This PR adds back the hotfix validation and properly removes the
options
parameter.