Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move type field to dist/esm/package.json #205

Merged
merged 3 commits into from
Oct 29, 2023

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Oct 29, 2023

Fixes #204 as suggested in #204 (comment).


PR-Codex overview

This PR focuses on fixing an error with TypeScript 5.2.2 in CommonJS projects.

Detailed summary

  • Added "type": "module" to the build:esm+types script in packages/abitype/package.json
  • Added "sideEffects": false to the build:esm+types script in packages/abitype/package.json

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2023

🦋 Changeset detected

Latest commit: 494a5d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
abitype Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@commit-lint
Copy link

commit-lint bot commented Oct 29, 2023

Bug Fixes

  • move type field to dist/esm/package.json (6fb325f)

Contributors

frangio, Raiden1411

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@vercel
Copy link

vercel bot commented Oct 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
abitype ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2023 9:37pm

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (32cf12d) 99.83% compared to head (494a5d9) 99.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #205   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files          26       26           
  Lines        6082     6082           
  Branches      195      195           
=======================================
  Hits         6072     6072           
  Misses          8        8           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Raiden1411
Copy link
Collaborator

Could you add a changeset?

@frangio
Copy link
Contributor Author

frangio commented Oct 29, 2023

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation issue with TypeScript 5.2.2
2 participants