-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: normalize AbiFallback.inputs
type between abitype
and zod
#203
Conversation
🦋 Changeset detectedLatest commit: d5dadf7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bug Fixes
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
=======================================
Coverage 99.83% 99.83%
=======================================
Files 26 26
Lines 6082 6082
Branches 195 195
=======================================
Hits 6072 6072
Misses 8 8
Partials 2 2
☔ View full report in Codecov by Sentry. |
I've tested the ABI output of the |
So you mean completely removing |
If @tmm agrees I would say so |
@Raiden1411 @tmm just wanted to know your opinion about removing fallback from fallback function |
6b36159
to
c706a9a
Compare
ffcd744
to
62b32d7
Compare
@Raiden1411's comment is spot on! Wasn't able to push to this PR for some reason so created a new one here #248 |
Description
This PR aligns the following
AbiFallback.inputs
type between Zod schema andabitype
After:
Additional Information
Before submitting this issue, please make sure you do the following.
PR-Codex overview
Focus of the PR:
This PR focuses on normalizing the
AbiFallback.inputs
type andzod
.Detailed summary:
AbiFallback.inputs
type andzod
packages/abitype/src/abi.ts
to usereadonly never[]
instead ofreadonly []
forAbiFallback.inputs
packages/abitype/src/zod.ts
to usez.tuple([]).readonly().optional()
forAbiFallback.inputs
AbiFallback
andAbiFunction
topackages/abitype/src/zod.test-d.ts
packages/abitype/src/zod.test-d.ts
AbiFunction
andAbiFallback
inpackages/abitype/src/zod.test-d.ts