fix: handle empty array and add type tests

wevm · Mar 13, 2024 · 9a03cf1 · 9a03cf1
1 parent 35f2c3f
commit 9a03cf1
Show file tree

Hide file tree

Showing 2 changed files with 52 additions and 2 deletions.
diff --git a/packages/abitype/src/human-readable/parseAbiParameters.test-d.ts b/packages/abitype/src/human-readable/parseAbiParameters.test-d.ts
@@ -109,4 +109,52 @@ test('parseAbiParameters', () => {
   expectTypeOf(parseAbiParameters(param)).toEqualTypeOf<
     readonly AbiParameter[]
   >()
+
+  expectTypeOf(parseAbiParameters(['(uint256 a),(uint256 b)'])).toEqualTypeOf<
+    readonly [
+      {
+        readonly type: 'tuple'
+        readonly components: readonly [
+          {
+            readonly type: 'uint256'
+            readonly name: 'a'
+          },
+        ]
+      },
+      {
+        readonly type: 'tuple'
+        readonly components: readonly [
+          {
+            readonly type: 'uint256'
+            readonly name: 'b'
+          },
+        ]
+      },
+    ]
+  >()
+
+  expectTypeOf(
+    parseAbiParameters(['(uint256 a)', '(uint256 b)']),
+  ).toEqualTypeOf<
+    readonly [
+      {
+        readonly type: 'tuple'
+        readonly components: readonly [
+          {
+            readonly type: 'uint256'
+            readonly name: 'a'
+          },
+        ]
+      },
+      {
+        readonly type: 'tuple'
+        readonly components: readonly [
+          {
+            readonly type: 'uint256'
+            readonly name: 'b'
+          },
+        ]
+      },
+    ]
+  >()
 })
diff --git a/packages/abitype/src/human-readable/parseAbiParameters.ts b/packages/abitype/src/human-readable/parseAbiParameters.ts
@@ -52,7 +52,9 @@ export type ParseAbiParameters<
               : never
           } extends infer Mapped extends readonly unknown[]
           ? Filter<Mapped, never> extends readonly [...infer Content]
-            ? DeepFlatten<Content>
+            ? Content['length'] extends 0
+              ? never
+              : DeepFlatten<Content>
             : never
           : never
         : never
@@ -142,5 +144,5 @@ export function parseAbiParameters<
   if (abiParameters.length === 0)
     throw new InvalidAbiParametersError({ params })
 
-  return abiParameters as unknown as ParseAbiParameters<TParams>
+  return abiParameters as ParseAbiParameters<TParams>
 }