WIP: add user/message.go #4
Conversation
Signed-off-by: dingdayu <[email protected]>
- add CacheMessagePayload to Puppet struct - add golang-lru require to go.mod Signed-off-by: dingdayu <[email protected]>
Signed-off-by: dingdayu <[email protected]>
Signed-off-by: dingdayu <[email protected]>
Signed-off-by: dingdayu <[email protected]>
Signed-off-by: dingdayu <[email protected]>
|
Thanks for your great questions, they are very insightful and valuable! For better discussion, I have split those three questions into different issues because the PR will be closed and the code reviews will become outdated when we push more code to the PR. The discussions have been created as #6 (naming style for go) and #7 (accessory questions) About the Go implementation of the abstract class, I'm not very familiar with the Go specifications, so I'm studying that right now. I Will let you know when I got any ideas about it. |
|
@SilkageNet Please help us by adding some comments to this PR. |
� Conflicts: � src/wechaty-puppet/schemas/image.go � src/wechaty-puppet/schemas/message.go � src/wechaty/user/contact.go � src/wechaty/user/image.go
Signed-off-by: dingdayu <[email protected]>
Signed-off-by: dingdayu <[email protected]>
| "github.com/wechaty/go-wechaty/src/wechaty-puppet/schemas" | ||
| ) | ||
|
|
||
| type Puppet interface { | ||
| type PuppetInterface interface { |
|
|
||
| FileName string | ||
| Text string | ||
| Timestamp int |
There was a problem hiding this comment.
我的代码里，timestamp使用的int64，可以考虑一下统一成哪种？
There was a problem hiding this comment.
Please align with our GRPC service: uint64.
See:
Thank you very much.
Signed-off-by: dingdayu <[email protected]>
I'm trying message.go but I have some trouble and want to set up a discussion.