Support queue's priorityclaas #99
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
@zbbkeepgoing Kindly to ask which issue is this PR related to?
link to volcano-sh/volcano#2660 |
|
@Thor-wl Any questions or suggestions about this pr&issue？and can it be merged？ |
@zbbkeepgoing Hey, sorry for the late reply. I've reviewed the issue and give some suggestions. Let's reivew the original scenarios first. |
link to design doc volcano-sh/volcano#2673, we have a discuss in the regular meeting last Friday |
|
/assign @Thor-wl |
pkg/apis/scheduling/types.go
Outdated
| // If not specified, the Queue priority will be default or zero if there is no | ||
| // default. | ||
| // +optional | ||
| PriorityClassName string |
There was a problem hiding this comment.
Why is there no json annotation here?
Signed-off-by: Binbin Zou <[email protected]> add priorityclassname's json annotation Signed-off-by: Binbin Zou <[email protected]>
Signed-off-by: Binbin Zou [email protected]