VE-3102: Update internalTaskId to type string #591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
|
ndthang15
requested review from
frankayars,
stefanminkov,
cantv6605-seta,
alex-oleksiiuk,
tfedoris-vt,
lucaspiscitello and
crondonveritone
|
Guid is string in sdk for now, so we don't need this change, and close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
internalTaskIdto type string for safety, because although aiware taskIds are guid but maybe edge taskIds can change to not guid in the future.Rely on the PR comment: https://github.com/veritone/aiware-core/pull/2383#discussion_r1670869478
Related Issue
https://veritone.atlassian.net/browse/VE-3102
How Has This Been Tested
npm i && npm run testin /packages/veritone-json-schemas folder.