Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Integration with fast_float #1170

Draft
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

swaingotnochill
Copy link

@swaingotnochill swaingotnochill commented Oct 15, 2024

See #1069

This is a draft pull request and the work is in progress.

The goal of this is to get timely feedback and reviews from the reviewers.

TODO:

  • Create the wrapper and archive it.
  • [] Replace it with strtod.
  • [] Benchmark it.
  • [] Run it on different platforms.

cc: @madolson @PingXie

@swaingotnochill swaingotnochill marked this pull request as draft October 15, 2024 00:48
@madolson
Copy link
Member

@parthpatel FYI.

If possible we would rather not take the C++ dependency, although that might be doable. Do you know how much effort it would be to port the code into C. The templating code seems very generic, but I don't think we need all the flexibility it is providing.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.72%. Comparing base (36d438b) to head (8a54ec2).
Report is 12 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1170      +/-   ##
============================================
+ Coverage     70.69%   70.72%   +0.02%     
============================================
  Files           114      114              
  Lines         61693    63006    +1313     
============================================
+ Hits          43611    44558     +947     
- Misses        18082    18448     +366     

see 97 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants