Explicitly handle timeouts when syncing channels

[NamelessOne91]

What does this PR change?

Related to https://github.com/SUSE/spacewalk/issues/25102

This PR forces failures in the case of an explicit Timeout Error when trying to sync existing repositories.
Cases in which a repository does not exist should still be handled by the StandardError branch

GUI diff

No difference.

• DONE

Documentation

• No documentation needed: only internal and user invisible changes

• DONE

Test coverage

• Cucumber tests were modified

• DONE

Links

Issue(s): # https://github.com/SUSE/spacewalk/issues/25102
Port(s):

• 5.0

• 4.3 (?)

• DONE

Changelogs

• No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

• Re-run test "changelog_test"
• Re-run test "backend_unittests_pgsql"
• Re-run test "java_pgsql_tests"
• Re-run test "schema_migration_test_pgsql"
• Re-run test "susemanager_unittests"
• Re-run test "javascript_lint"
• Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

[github-actions]

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9344/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9344/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

• https://github.com/uyuni-project/uyuni/actions/workflows/acceptance_tests_secondary_parallel.yml?query=event%3Aschedule

• https://github.com/uyuni-project/uyuni/actions/workflows/acceptance_tests_secondary.yml?query=event%3Aschedule

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

[maximenoel8]

Be careful with rising an error. We don't want to rise error if no repository is declared or no package is in the repository.
Example: Empty MU https://github.com/SUSE/spacewalk/blob/19866877e62433aadce9d077297c5718e794b5e5/testsuite/features/build_validation/add_MU_repositories/add_maintenance_update_repositories.template

[maximenoel8]

Probably having no packages to sync is more an exception than a normal case. We could have an enable disable option to check fail on reposync. By digging into the CHANNEL_TO_SYNC_BY_OS_PRODUCT_VERSION, I can see some channel are not correct.

[NamelessOne91]

Be careful with rising an error. We don't want to rise error if no repository is declared or no package is in the repository. Example: Empty MU https://github.com/SUSE/spacewalk/blob/19866877e62433aadce9d077297c5718e794b5e5/testsuite/features/build_validation/add_MU_repositories/add_maintenance_update_repositories.template

Will this case result in an error being raised ?
If so, I'd expect it to not be a TimeOutError but something else that enters the branch where we rescue for StandardError, where it seems we suppress errors if we're on a build validation run

[srbarrios]

Why we need this begin statement catching StandardError and Timeout while in fact that's already addressed as part of repeat_until_timeout function?
I think we are duplicating the error handling logic on that step definition.

See this:
https://github.com/NamelessOne91/uyuni/blob/master/testsuite/features/support/commonlib.rb#L121-L126

[NamelessOne91]

Right, we can probably remove the error handling from the caller and just pass $build_validation as dont_raise, if we intend to suppress errors

[srbarrios]

Exactly.