WIP - FEATURE BRANCH - 214 - Refactor Feature Testing #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janell-Huyck
force-pushed
the
214-feature-branch-refactor-feature-testing
branch
3 times, most recently
from
b148319
to
5bf3ab7
Compare
Janell-Huyck
force-pushed
the
214-feature-branch-refactor-feature-testing
branch
from
91b27a5
to
91fc199
Compare
|
Is this ready for review? |
|
Thanks for asking, Sean. It's not, because we're looking at adding some functionality - editing reports - that the tests revealed was missing. Consider this still a WIP for now. |
Janell-Huyck
changed the title
Janell-Huyck
force-pushed
the
214-feature-branch-refactor-feature-testing
branch
from
0a8e1da
to
07192ba
Compare
* Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time
…481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop:
…GE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution
…#487) * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests
* Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix broken test
* Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix more broken tests
* Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix more broken tests * Test creating a new user * Fix failing test
* Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix more broken tests * Test creating a new user * WIP - Edit User Specs * Fix broken tests
…IRST (#492) * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix more broken tests * Test creating a new user * WIP - Edit User Specs * Fix broken tests * Migrate controlled vocab creation specs * Correct spelling name of test
…RST (#493) * Edit controlled vocab specs * Fix flaky tests
…IRST (#494) * Edit controlled vocab specs * Check read-only cons records for access rights * Remove blank lines, correct disabled fields test
* Edit controlled vocab specs * Check read-only cons records for access rights * Remove blank lines, correct disabled fields test * Rearrange feature tests by subject, add in-house creation testing * Check in-house repair deletion * Rubocop and fix broken tests
* Use global constant for SHIBBOLETH_ENABLED * Remove sensitive environment files from repository * Rubocop fix * Update 'rake' to ''rails' and remove .env* from .gitignore * Re-add .env development and test files * Correct .env errors * Remove rake task to check SSO environment variable
Janell-Huyck
force-pushed
the
214-feature-branch-refactor-feature-testing
branch
from
fe6ae1a
to
7279dd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #214
This is a feature branch for refactoring this app's feature tests. It will include shared examples, helper functions, and shared contexts.