Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor component will receive props #1343

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Xiot
Copy link
Contributor

@Xiot Xiot commented May 31, 2020

Rebased #1253 and fixed up the tests.

Changes the usages of componentWillReceiveProps to componentDidUpdate.
This does change up the timing a little but, which is why there is an extra update() on the tests.
I've run through the storybook and everything looks like everything is still working

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ DiegoGorgazzi
❌ Chris Thomas


Chris Thomas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants