5.1: Deprecate CheckConstraint.check #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
q0w
force-pushed
the
me-check-constraint
branch
from
d28a5ac
to
d601f6e
Compare
sobolevn
reviewed
Aug 9, 2024
Viicos
reviewed
Aug 21, 2024
sobolevn
reviewed
Aug 22, 2024
asottile-sentry
pushed a commit
to getsentry/sentry-forked-django-stubs
that referenced
this pull request
Sep 11, 2024
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
asottile-sentry
added a commit
to getsentry/sentry-forked-django-stubs
that referenced
this pull request
Sep 11, 2024
* add cache_name for django 5.1 (typeddjango#2365) * 5.1: Deprecate CheckConstraint.check (typeddjango#2331) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --------- Co-authored-by: Anthony Sottile <[email protected]> Co-authored-by: q0w <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
https://github.com/django/django/blob/ecf13f192de7c26a7606f5ba46a3773a9c84ef72/django/db/models/constraints.py#L137
Added overload to forbid check=None, condition=None at the same
Related issues