Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Obsolete Config Rules #189

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Remove Obsolete Config Rules #189

merged 2 commits into from
Nov 6, 2023

Conversation

chtakahashi
Copy link
Contributor

  • EC2-Classic is now retired so instances must be attached to a VPC by default.
  • S3 encryption is now the default.

esacteksab
esacteksab approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@esacteksab esacteksab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran tfsort against variables.tf. I'm why we can't have nice things in this instance. Thank you for doing this.

@chtakahashi chtakahashi merged commit a9e8c9c into main Nov 6, 2023
1 check passed
@chtakahashi chtakahashi deleted the remove-obsolete-rules branch November 6, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esacteksab esacteksab esacteksab approved these changes

@mdrummerboy09 mdrummerboy09 mdrummerboy09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chtakahashi @esacteksab @mdrummerboy09