Onewire improvements #706
Open
Onewire improvements #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HattoriHanzo031
force-pushed
the
onewire_improvements
branch
from
5d3715f
to
8d4deb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements to OneWire/DS18B20 driver.
Although external pull-up resistor for DS18B20 is recommended, internal pull-up is good enough in some cases (for example for single sensor on a short bus), so low level functions are changed to enable internal pull-up for high state.
While testing DS18B20 sensor without internal or external pull-up, I got panic because OneWire
Searchfunction "found" more than 32 devices and overflowed the array. To prevent this, the check is added to stop the search (and return an error) when more than 32 devices are found. Also, CRC check was added to prevent adding invalid devices during search.Additionally PR contains suggestion for changing
Crc8method and in turnOneWireDeviceinterface (which is a breaking change) to be a bit more idiomatic Go. This is only a suggestion and I would like to get other opinions on it.