Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable new cops by default & fix many cops #876

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Sep 26, 2023

No description provided.

@@ -91,7 +91,7 @@ def create_migration_dirs
end

def underscore(src)
src = src.gsub(/::/, '/')
src = src.gsub("::", '/')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would '::' also work? (I would have expected 👮 to yell at you)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this repo that cop is disabled. I'm not sure why RuboCop would prefer ".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, very well, then something for the future.

@@ -0,0 +1,23 @@
#!/usr/bin/env ruby
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this file added and how does it fix the Style/RedundantConstantBase cop?

not that I mind adding it, just puzzled how it fits into this PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wonders of git add with some local file that you didn't intend to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants