Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #30857 - Merge puppet_proxy_puppet_api into mod #771

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Sep 16, 2020

In 7e7015a the legacy provider was dropped. Since then, there is only one provider. The provider code was kept since it didn't need any changes to configuration files. However, having a module with just a single provider is complex. Both from a code perspective and as an admin.

The implications are that the puppet.yaml and puppet_proxy_puppet_api.yaml files are merged (after being split in df0fc72). This means installer and manual updates are needed to reflect this.

For now it's a draft since I didn't do a lot of testing on this. The major open question is migration of the config files. Right now it just drops the automated migration that splits it, but doesn't have a migration to merge them again. Reviews, thoughts and opinions are welcome though.

In 7e7015a the legacy provider was
dropped. Since then, there is only one provider. The provider code was
kept since it didn't need any changes to configuration files. However,
having a module with just a single provider is complex. Both from a code
perspective and as an admin.

The implications are that the puppet.yaml and
puppet_proxy_puppet_api.yaml files are merged (after being split in
df0fc72). This means installer and
manual updates are needed to reflect this.
@ekohl ekohl force-pushed the 30857-merge-puppet-provider branch from 5ea790a to efe845c Compare August 31, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants