Rate limit implementation #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's ok for now, If anyone has any corrections/suggestions please feel free to add :) |
pedro-cf
requested review from
jamesfisher-geo,
jonhealy1 and
StijnCaerts
and removed request for
jamesfisher-geo and
jonhealy1
jamesfisher-geo
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
This looks great to me. I'll leave it for a day to give others a chance to review @jonhealy1 @StijnCaerts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implementation of address based global rate limiting option.
Rate limiting is an optional security feature that controls API request frequency on a remote address basis. It's enabled by setting the
STAC_FASTAPI_RATE_LIMITenvironment variable, e.g.,500/minute. This limits each client to 500 requests per minute, helping prevent abuse and maintain API stability. Implementation examples are available in the examples/rate_limit directory.PR Checklist:
pre-commit run --all-files)make test)