Skip to content

Commit

Permalink
Fix make test (#287)
Browse files Browse the repository at this point in the history
**Description:**

`make test` references an undefined variable, `APP_PORT`, which causes
the the `docker-compose` command's `-p` argument to be malformed:

```
docker-compose run -p  :8080 ...
                      ^--- missing the left-side port!
```

**PR Checklist:**

- [x] Code is formatted and linted (run `pre-commit run --all-files`)
- [x] Tests pass (run `make test`)
      _The test failure in CI appears to be unrelated to this change._
- [ ] Documentation has been updated to reflect changes, if applicable
- [ ] Changes are added to the changelog
  • Loading branch information
kurtmckee authored Aug 23, 2024
1 parent 516e968 commit 9a51574
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!make
APP_HOST ?= 0.0.0.0
EXTERNAL_APP_PORT ?= ${APP_PORT}
EXTERNAL_APP_PORT ?= 8080

ES_APP_PORT ?= 8080
ES_HOST ?= docker.for.mac.localhost
Expand Down

0 comments on commit 9a51574

Please sign in to comment.