Skip to content

Commit

Permalink
switch from server_version to server_version_num (#304)
Browse files Browse the repository at this point in the history
  • Loading branch information
vincentsarago authored Sep 17, 2024
1 parent 858a984 commit a3a3f26
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 5 deletions.
9 changes: 6 additions & 3 deletions src/pypgstac/python/pypgstac/db.py
Original file line number Diff line number Diff line change
Expand Up @@ -271,15 +271,18 @@ def pg_version(self) -> str:
"""Get the current pg version number from a pgstac database."""
version = self.query_one(
"""
SHOW server_version;
SHOW server_version_num;
""",
)
logger.debug(f"PG VERSION: {version}.")
if isinstance(version, bytes):
version = version.decode()
if isinstance(version, str):
if int(version.split(".")[0]) < 13:
raise Exception("PgSTAC requires PostgreSQL 13+")
if int(version) < 130000:
major, minor, patch = tuple(
map(int, [version[i:i + 2] for i in range(0, len(version), 2)]),
)
raise Exception(f"PgSTAC requires PostgreSQL 13+, current version is: {major}.{minor}.{patch}") # noqa: E501
return version
else:
if self.connection is not None:
Expand Down
12 changes: 10 additions & 2 deletions src/pypgstac/python/pypgstac/migrate.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,16 @@ def run_migration(self, toversion: Optional[str] = None) -> str:
logger.info("using unreleased version")
toversion = "unreleased"

pg_version = self.db.pg_version
logger.info(f"Migrating PgSTAC on PostgreSQL Version {pg_version}")
major, minor, patch = tuple(
map(
int,
[
self.db.pg_version[i:i + 2]
for i in range(0, len(self.db.pg_version), 2)
],
),
)
logger.info(f"Migrating PgSTAC on PostgreSQL Version {major}.{minor}.{patch}")
oldversion = self.db.version
if oldversion == toversion:
logger.info(f"Target database already at version: {toversion}")
Expand Down

0 comments on commit a3a3f26

Please sign in to comment.