Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to paste custom annotations to CRD in Helm chart #631

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Add ability to paste custom annotations to CRD in Helm chart #631

merged 3 commits into from
Aug 16, 2023

Conversation

EsDmitrii
Copy link
Contributor

Hi!
I faced issues when tried to deploy redis-operator via ArgoCD

CustomResourceDefinition.apiextensions.k8s.io "redisfailovers.databases.spotahome.com" is invalid: metadata.annotations: Too long: must have at most 262144 bytes

To fix this issue I need to paste special annotation for ArgoCD.
I can't do this via values file, and I need to download chart locally, make changes and deploy.
I added ability to add special custom annotations via values.yaml file.

@EsDmitrii EsDmitrii requested a review from a team as a code owner July 6, 2023 07:50
added ability to specify custom annotations
@EsDmitrii EsDmitrii changed the title Update databases.spotahome.com_redisfailovers.yaml Add ability to paste custom annotations to CRD Jul 6, 2023
@EsDmitrii EsDmitrii changed the title Add ability to paste custom annotations to CRD Add ability to paste custom annotations to CRD in Helm chart Jul 6, 2023
@ese
Copy link
Member

ese commented Aug 16, 2023

Thanks!, Im happy to merge this if you merge with master and fix the conflicts

@EsDmitrii
Copy link
Contributor Author

@ese Hi! Conflicts are fixed.

@ese ese merged commit 8974171 into spotahome:master Aug 16, 2023
6 checks passed
@EsDmitrii EsDmitrii deleted the patch-1 branch August 17, 2023 07:55
@liupeng0518
Copy link

merged this pr has err:

❯ helm upgrade --install redis-operator redis-operator/redis-operator --version 3.3.0                                                                                          ─╯
Error: failed to install CRD crds/databases.spotahome.com_redisfailovers.yaml: error parsing : error converting YAML to JSON: yaml: line 4: did not find expected node content
helm.go:84: [debug] error parsing : error converting YAML to JSON: yaml: line 4: did not find expected node content

@sergey-kudriavtsev
Copy link

@EsDmitrii Please check the work

@EsDmitrii
Copy link
Contributor Author

EsDmitrii commented Jan 19, 2024

sorry for the long response, I'm working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants