Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5.2 #62

Open
wants to merge 1 commit into
base: v5.2
Choose a base branch
from
Open

V5.2 #62

wants to merge 1 commit into from

Conversation

JC53489
Copy link

@JC53489 JC53489 commented Aug 20, 2024

I have updated the deployment scripts in the ollama prototype as well as the readme to reflect how they should be used. The old versions no longer worked as the dev container had been removed from the target docker-compose.yml.

@JC53489 JC53489 marked this pull request as ready for review August 20, 2024 14:46
@pdrieger
Copy link
Collaborator

Thanks @JC53489 that's great you found time to commit these changes, I would like to get @huaibo-zhao-splunk 's view on this too. Happy to get this merged in then soon. Thanks again and chat soon :)

@huaibo-zhao-splunk
Copy link
Contributor

Thanks @JC53489 for finding your time to work on this. I noticed that you are combining the docker compose files of ollama and milvus into one single file. I think maybe it is better to keep them separated, in the case where users only want to use one module instead of the whole set.
Meanwhile, for the installation steps in the official documentation, I am asking the users to execute the following steps:

First, wget the two docker compose files from this github repo v5.2 branch. 
Second, run the docker compose command with the files on their docker host to start the dependent containers for Ollam and Milvus.
Third, start the LLM-RAG DSDL container on the DSDL container management page. 

Changing the compose file name/directory might require more changes on the documentation side as well.

@huaibo-zhao-splunk
Copy link
Contributor

@JC53489 But yes, since your changes are only for the passive deployment case and does not change/affect the current existing files and their locations, I think it is brilliant and am totally okay with it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants