feat(gce): add partnerMetadata in instanceProperties for GCE deployment #6297
+16
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarulg
requested review from
jasonmcintosh,
link108,
christosarvanitis and
dbyron-sf
jasonmcintosh
approved these changes
Oct 17, 2024
|
Just added the metadata to the objects... orca's the bigger area in a sense... not sure there's a good way to test parsing of fields on this kinda thing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support partnerMetadata in GCE deployment. See https://cloud.google.com/compute/docs/metadata/overview#partner_attributes
Basically clouddriver will receive partnerMetadata from the execution context and it will add it in the instanceProperties if partnerMetadata is defined.
PartnerMetadata is a feature under Preview but clouddriver currently uses beta google compute client and it recognizes it.
If there is an error in the structure of the parterMetadata the deployment will fail and it will describe the error like the following:
We can validate that the instance template & instance itself has the partnerMetadata by using the following beta command in gcloud.
gcloud beta compute instance-templates describe armorytests-v005-92753465 --view=FULLgcloud beta compute instances describe armorytests-v005-5mxg --view=FULLIssue related: spinnaker/spinnaker#6931
PartnerMetadata is available in clouddriver because the newer client version: spinnaker/kork#1208