Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support mautrix bridgev2 / megabridge APIs #3577

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ignyx
Copy link
Contributor

@ignyx ignyx commented Oct 7, 2024

New versions of the mautrix go bridges include standardized HTTP endpoints that can be used to log in and manage sessions (spec). Some clients may choose to provide interfaces. At this time, mautrix-manager can consume these endpoints. An auto-discovery .well-known file can be set.

This PR aims to make these endpoints public and setup auto-discovery.

Please let me know :

  • whether this can be useful
  • whether the mautrix-messenger implementation is acceptable, to serve as a baseline for the next bridges
  • any recommendations

@ignyx ignyx force-pushed the feat-enable-mautrix-bridgev2-api branch from 6baa7ce to 61851df Compare October 7, 2024 13:56
Copy link
Owner

@spantaleev spantaleev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

How does authentication work?

Have you got mautrix-manager working and successfully accessing the Messenger bridge's bridgev2 API?

@@ -8,6 +8,7 @@
with_items:
- {'name': 'matrix_mautrix_meta_messenger_metrics_proxying_hostname', when: "{{ matrix_mautrix_meta_messenger_metrics_proxying_enabled }}"}
- {'name': 'matrix_mautrix_meta_messenger_metrics_proxying_path_prefix', when: "{{ matrix_mautrix_meta_messenger_metrics_proxying_enabled }}"}
- {'name': 'matrix_mautrix_meta_messenger_container_labels_bridgev2_traefik_hostname', when: "{{ matrix_mautrix_meta_messenger_metrics_proxying_enabled }}"}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- {'name': 'matrix_mautrix_meta_messenger_container_labels_bridgev2_traefik_hostname', when: "{{ matrix_mautrix_meta_messenger_metrics_proxying_enabled }}"}
- {'name': 'matrix_mautrix_meta_messenger_container_labels_bridgev2_traefik_hostname', when: "{{ matrix_mautrix_meta_messenger_container_labels_bridgev2_enabled }}"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants