Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 #61

Merged
merged 5 commits into from
May 3, 2024
Merged

V2 #61

merged 5 commits into from
May 3, 2024

Conversation

YoshiyukiMineo
Copy link
Member

No description provided.

zalgonoise and others added 5 commits May 1, 2024 00:03
…54)

* gobreaker/v2: added generics implementation in v2 module

* gobreaker/v2/example: added v2 example

* gobreaker/README: updated README.md

* fixup! gobreaker/v2: added generics implementation in v2 module

---------

Co-authored-by: Yoshiyuki Mineo <[email protected]>
@YoshiyukiMineo YoshiyukiMineo merged commit 8c718af into master May 3, 2024
4 checks passed
@YoshiyukiMineo YoshiyukiMineo deleted the v2 branch May 3, 2024 07:38
// with the breaker functionality, it only checks whether a request can proceed and
// expects the caller to report the outcome in a separate step using a callback.
type TwoStepCircuitBreaker[T any] struct {
cb *CircuitBreaker[T]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this type doesn’t use the type parameter at all, this could have just wrapped *CircuitBreaker[struct{}] rather than bubbling up an unnecessary type param into this type?

I suppose, removing the type parameter would now be a breaking change, though…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants