Allow configuration of logger and build version in gvisor service lib… #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of gvisor exposes
service.Newas the entry point. Inside there,nebula.Mainis configured. This preventsnebula.Mainbeing customised with a logger or build version.This PR changes
service.Newfrom taking a config file to taking*nebula.Controlgenerated bynebula.Maininstead.I considered allowing passing in the logger and build version, but as
nebula.Mainis the main entry point for Nebula, and exposed (i.e. a capitalM) it seems logical that this is not hidden within the service function.