Correctly forward number of methods to the originals in Compact / Readable wrappers
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deserializer in Compact / Readable wrappers For historical reasons Deserializer trait has default implementation for 128-bit integers which returns error, so it is important to not forgot to re-implement those methods.
…ializer in Compact / Readable wrappers For historical reasons Serializer trait has default implementation for 128-bit integers which returns error, so it is important to not forgot to re-implement those methods.
…Compact / Readable wrappers
…h wrapped deserializer Although this is private serde API, not forwarding it would be error. Unfortunately, another private API, Deserializer::__deserialize_content, cannot be implemented because it accepts private type from serde
Mingun
changed the title
Compact / Readable wrappers
dtolnay
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Thanks!
I am merging this without the 8th commit (__private_visit_untagged_option). That is not provided by serde as a public API, and using it from this crate would expose the risk of serde_test failing to compile if the signature of that function changes in any future version of serde. I am open to other options for serving that use case, including potentially stabilizing an API in serde if there is one that makes sense to provide publicly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a numerous of bugs:
serialize_i128/serialize_u128deserialize_i128/deserialize_u128visit_i128/visit_u128SerializeMap::serialize_entry, fixes Readable/Compact still give "must use Configure" error when serializing Map #34deserialize_in_placecollect_seq/collect_mapskip_fieldandcollect_strto the originalsDeserializer::__deserialize_contentalso should be reimplemented to work correctly, but unfortunately this is impossible because of the efforts that have been made to ban that