build: suppress CMake warning about CMP0057 #2503
Open
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when building a project by consuming Seastar's CMake config files,
if the parent project does not set the policy CMP0057, CMake warns:
```
CMake Warning (dev) at /tmp/seastar/lib64/cmake/Seastar/FindSanitizers.cmake:53 (if):
Policy CMP0057 is not set: Support new IN_LIST if() operator. Run "cmake
--help-policy CMP0057" for policy details. Use the cmake_policy command to
set the policy and suppress this warning.
IN_LIST will be interpreted as an operator when the policy is set to NEW.
Since the policy is not set the OLD behavior will be used.
Call Stack (most recent call first):
/usr/share/cmake/Modules/CMakeFindDependencyMacro.cmake:76 (find_package)
/tmp/seastar/lib64/cmake/Seastar/SeastarDependencies.cmake:55 (find_dependency)
/tmp/seastar/lib64/cmake/Seastar/SeastarDependencies.cmake:98 (seastar_find_dep)
/tmp/seastar/lib64/cmake/Seastar/SeastarConfig.cmake:56 (seastar_find_dependencies)
CMakeLists.txt:5 (find_package)
This warning is for project developers. Use -Wno-dev to suppress it.
CMake Error at /tmp/seastar/lib64/cmake/Seastar/FindSanitizers.cmake:53 (if):
if given arguments:
"address" "IN_LIST" "Sanitizers_FIND_COMPONENTS"
Unknown arguments specified
Call Stack (most recent call first):
/usr/share/cmake/Modules/CMakeFindDependencyMacro.cmake:76 (find_package)
/tmp/seastar/lib64/cmake/Seastar/SeastarDependencies.cmake:55 (find_dependency)
/tmp/seastar/lib64/cmake/Seastar/SeastarDependencies.cmake:98 (seastar_find_dep)
/tmp/seastar/lib64/cmake/Seastar/SeastarConfig.cmake:56 (seastar_find_dependencies)
CMakeLists.txt:5 (find_package)
```
it is the library's responsibility to provide a warning-free CMake
module, so let's silence this warning. as we are indeed using `IN_LIST`
as an operator in `if` clause.
Signed-off-by: Kefu Chai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when building a project by consuming Seastar's CMake config files, if the parent project does not set the policy CMP0057, CMake warns:
it is the library's responsibility to provide a warning-free CMake module, so let's silence this warning. as we are indeed using
IN_LISTas an operator inifclause.