test: Add perf test for http client #2442
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
reviewed
Sep 18, 2024
xemul
force-pushed
the
br-http-perf-test
branch
from
e25b6ba
to
4cf0e71
Compare
|
upd:
|
|
@tchaikov , CI fails compiling a file that's not touched by this PR: |
|
lemme check. |
i can reproduce this with GCC-14 on fedora 40. seems it's related to ADL. |
xemul
force-pushed
the
br-http-perf-test
branch
from
4cf0e71
to
8145146
Compare
|
Thanks! Rebased the branch |
nyh
reviewed
Sep 22, 2024
xemul
force-pushed
the
br-http-perf-test
branch
from
8145146
to
ae6e7c4
Compare
|
upd:
|
avikivity
reviewed
Sep 24, 2024
| @@ -88,3 +88,7 @@ seastar_add_test (allocator | |||
|
|
|||
| seastar_add_test (container | |||
There was a problem hiding this comment.
It uses in-memory loopback sockets (seastar wrapper around seastar::queue).
But I already prepared mentally to write a comment about it
avikivity
reviewed
Sep 24, 2024
| co_return; | ||
| } | ||
|
|
||
| _req += sstring(buf.get(), buf.size()); |
There was a problem hiding this comment.
This is quadratic, but I expect n=1, so n²=1 too
avikivity
reviewed
Sep 24, 2024
avikivity
reviewed
Sep 24, 2024
| }); | ||
| return when_all(std::move(sf), std::move(cf)).discard_result(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
coroutine or thread?
Would be nicer to report insn/op and allocs/op.
There was a problem hiding this comment.
Thread looks nicer indeed
Report usec/op and allocs/op
There was a problem hiding this comment.
Why not insn/op (in addition)? It's more stable with todays frequency agile processors.
There was a problem hiding this comment.
Hm... Where to look for an example that collects instructions for a perf test?
There was a problem hiding this comment.
if we don't plan to use PERF_TEST because it's complicated to pass command line arguments to the individual tests. probably we can still use linux_perf_event::user_instructions_retired() directly ?
The test opens a server socket that reads socket up until double CRLF and then responds back with "HTTP/1.1 200 OK host: test" line in a loop. Then runs http client against it measuring time it takes to perform the given amount of requests. It uses in-memory loopback sockets (seastar wrapper around seastar::queue). Signed-off-by: Pavel Emelyanov <[email protected]>
xemul
force-pushed
the
br-http-perf-test
branch
from
ae6e7c4
to
41c0799
Compare
|
upd:
|
|
@avikivity , @nyh , reminder ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test opens a server socket that reads socket up until double CRLF and then responds back with "HTTP/1.1 200 OK host: test" line in a loop. Then runs http client against it measuring time it takes to perform the given amount of requests. It uses in-memory loopback sockets (seastar wrapper around seastar::queue).